-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open vmax
and vmin
access in yasa.plot_spectrogram()
#73
Labels
enhancement 🚧
New feature or request
Comments
Hi @matiasandina, Good idea. It should be pretty straightforward to implement. Do you want to submit a PR? Or I'll work on it for the next release. Thanks, |
I'm about to head out for vacation, I can take a look at it in 2-3 weeks at
minimum.
El mié, 8 jun 2022 a las 12:41, Raphael Vallat ***@***.***>)
escribió:
… Hi @matiasandina <https://github.com/matiasandina>,
Good idea. It should be pretty straightforward to implement. Do you want
to submit a PR? Or I'll work on it for the next release.
Thanks,
Raphael
—
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABZF2N4VC5ZXJIW66J4T4ULVODEJZANCNFSM5YDDEAMA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Turns out I needed it myself and it was way easier than what I thought. Will submit a PR soon
Trying to test it for failure
Results in
|
matiasandina
added a commit
to matiasandina/yasa
that referenced
this issue
Jun 9, 2022
raphaelvallat
added a commit
that referenced
this issue
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not always useful, but sometimes you want to plot different channels on a common scale.
I think
plot_spectrogram()
could havevmax=None
andvmin=None
and, if supplied, they would overrule the normalization of the colormap.It might be that this can be done once the spectrogram is but I'm not so fluent in matplotlib to do so.
The text was updated successfully, but these errors were encountered: