Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for MNE plot_topomap deprecation #119

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Conversation

raphaelvallat
Copy link
Owner

@raphaelvallat raphaelvallat commented Dec 23, 2022

Avoid TypeError: plot_topomap() got an unexpected keyword argument 'vmin' in MNE v1.3

@raphaelvallat raphaelvallat self-assigned this Dec 23, 2022
@raphaelvallat raphaelvallat added the bug 💥 Something isn't working label Dec 23, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 91.70% // Head: 91.64% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (b7f204b) compared to base (8f807e0).
Patch coverage: 62.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   91.70%   91.64%   -0.06%     
==========================================
  Files          22       22              
  Lines        2748     2753       +5     
==========================================
+ Hits         2520     2523       +3     
- Misses        228      230       +2     
Impacted Files Coverage Δ
yasa/plotting.py 96.83% <62.50%> (-1.86%) ⬇️
yasa/detection.py 97.85% <0.00%> (+0.11%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raphaelvallat raphaelvallat merged commit ca4a834 into master Dec 23, 2022
@raphaelvallat raphaelvallat deleted the hotfix_mne_deprecation branch December 23, 2022 15:55
@raphaelvallat raphaelvallat mentioned this pull request Jan 8, 2023
7 tasks
@raphaelvallat raphaelvallat linked an issue Apr 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 💥 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while using topoplot() function
2 participants