Passing relative_prominence in rem_detect()
#151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulroujansky
force-pushed
the
passing_relative_prominence_in_rem_detect
branch
from
fb80cac
to
d232711
Compare
raphaelvallat
approved these changes
Sep 30, 2023
sjg2203
pushed a commit
to sjg2203/yasa
that referenced
this pull request
Feb 12, 2024
Co-authored-by: Paul ROUJANSKY <paul.roujansky@bioserenity.com> (cherry picked from commit 9608fa4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
A small suggestion to pass the relative prominence used for REM peak detection instead of hardcoding the value in
rem_detect()🙂This helps to perform hypertuning.