Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #59
MNE automatically scales EEG (and EOG, EMG, ECG data) to Volts. YASA however expect the data to be in micro-Volts. The current behavior of YASA is to manually scale the data by 1e6 to convert from Volts to uV:
With this PR, the conversion is now performed directly within the mne.Raw.get_data() function, using the
units
argument (added in MNE 0.23.0):This converts the EEG, EMG, EOG and ECG data to uV, while leaving the other channel types in their original MNE units.
Can someone please review this PR before June 20, 2022?
PS: I'll update the changelog once #68 is merged.
Thank you,
Raphael