Skip to content
This repository has been archived by the owner on Mar 26, 2024. It is now read-only.

renderer: test injectIntoDevTools #36

Closed
wants to merge 1 commit into from

Conversation

raphamorim
Copy link
Owner

@nitin42
Copy link

nitin42 commented Nov 6, 2017

I've tested the PR facebook/react#11463 and it is working. Just waiting for the React team to merge this into the react-reconciler package. I kinda like this behaviour, put injectIntoDevTools directly on reconciler instance return value.

@raphamorim
Copy link
Owner Author

raphamorim commented Nov 6, 2017

Nice, you made it more faster than me hehe
So, I'll wait for next version of react-renderer.

@nitin42
Copy link

nitin42 commented Nov 6, 2017

Wait.. I'm giving you the exact production files so you can also test this right now!

@raphamorim
Copy link
Owner Author

raphamorim commented Nov 6, 2017

Thanks!
I tested it and no more issue about injectIntoDevTools reference 👍

@nitin42
Copy link

nitin42 commented Nov 6, 2017

Awesome!

@nitin42
Copy link

nitin42 commented Nov 8, 2017

Well, the PR has been merged into react-reconciler master!

@raphamorim
Copy link
Owner Author

Nice @nitin42! Thanks for reporting it :D

@raphamorim raphamorim mentioned this pull request Nov 8, 2017
5 tasks
@raphamorim raphamorim mentioned this pull request Dec 6, 2017
@raphamorim
Copy link
Owner Author

Closed by #123

@raphamorim raphamorim closed this Jun 3, 2018
@raphamorim raphamorim deleted the feature/injectIntoDevTools branch June 3, 2018 20:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants