Run Ubuntu 22.04 in test matrix #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
force-pushed
the
run-ubuntu-22.04-in-test-matrix
branch
5 times, most recently
from
b4b26db
to
e0dac97
Compare
adfoster-r7
commented
Jul 19, 2022
Gemfile
Outdated
| @@ -8,8 +8,6 @@ group :development do | |||
| end | |||
|
|
|||
| group :test do | |||
| # simplecov test formatter and uploader for Coveralls.io | |||
| gem "coveralls", '~>0.8.23', :require => false | |||
There was a problem hiding this comment.
This has been dead since 2020, and the endpoint raises SSL exceptions now - potentially due to not providing an auth token.
adfoster-r7
force-pushed
the
run-ubuntu-22.04-in-test-matrix
branch
6 times, most recently
from
f2c36bc
to
bc4b12b
Compare
adfoster-r7
commented
Jul 20, 2022
adfoster-r7
force-pushed
the
run-ubuntu-22.04-in-test-matrix
branch
from
bc4b12b
to
ff7b521
Compare
adfoster-r7
commented
Jul 21, 2022
adfoster-r7
commented
Jul 21, 2022
lib/ruby_smb/signing.rb
Outdated
| @@ -12,8 +12,8 @@ module Signing | |||
| # @param [RubySMB::GenericPacket] packet The packet to sign. | |||
| # @return [RubySMB::GenericPacket] the signed packet | |||
| def smb1_sign(packet) | |||
| packet = Signing::smb1_sign(packet, @session_key, @sequence_counter) | |||
There was a problem hiding this comment.
The tests were mocking the session_key accessor, but not the @session_key instance variable. As a result, OpenSSL 3 was throwing validation errors that '' was an invalid key.
adfoster-r7
commented
Jul 21, 2022
| # Enable legacy providers | ||
| ENV['OPENSSL_CONF'] = File.expand_path( | ||
| File.join(File.dirname(__FILE__), 'support', 'openssl.conf') | ||
| ) |
There was a problem hiding this comment.
OpenSSL 3 no longer loads old cyphers by default. This allows the tests to pass. Metasploit-framework will have this file loaded at runtime.
Unfortunately it means direct users of RubySMB will need a similar configuration change. Or we will need to wait for a solution similar to WinRb/rubyntlm#53 to land
adfoster-r7
force-pushed
the
run-ubuntu-22.04-in-test-matrix
branch
from
ff7b521
to
46fcbdb
Compare
cdelafuente-r7
approved these changes
Aug 2, 2022
…ed for Samba servers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to rapid7/metasploit-framework#16818
Let's run Ubuntu 22.04 in our test matrix, to catch any OpenSSL v3 regression issues
Behind the scenes this depended on two changes to dependencies:
Currently not a blocker to this particular PR - but additional changes to RubyNTLM will be required. Such as:
Verification