Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruby versions #245

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

adfoster-r7
Copy link
Contributor

@adfoster-r7 adfoster-r7 commented Jan 18, 2023

Fixes the following error:


Failures:

  1) RubySMB::Dcerpc::Winreg#enum_registry_values calls #enum_key the expected number of times
     Failure/Error: expect(winreg).to have_received(:enum_value).with(subkey_handle, instance_of(Fixnum)).twice

     NameError:
       uninitialized constant Fixnum
     # ./spec/lib/ruby_smb/dcerpc/winreg_spec.rb:713:in `block (3 levels) in <top (required)>'

  2) RubySMB::Dcerpc::Winreg#enum_registry_key calls #enum_key the expected number of times
     Failure/Error: expect(winreg).to have_received(:enum_key).with(subkey_handle, instance_of(Fixnum)).twice

     NameError:
       uninitialized constant Fixnum
     # ./spec/lib/ruby_smb/dcerpc/winreg_spec.rb:634:in `block (3 levels) in <top (required)>'

@smcintyre-r7 smcintyre-r7 self-assigned this Jan 18, 2023
@smcintyre-r7 smcintyre-r7 merged commit efcf226 into rapid7:master Jan 18, 2023
@smcintyre-r7
Copy link
Contributor

This is an actions specific problem. I see that the tests are running correctly now so I've gone ahead and merged this fix in. Thanks alot @adfoster-r7 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants