Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace local copyright check with pre-commit-hooks verify-copyright #5732

Merged
merged 12 commits into from
Mar 12, 2024
Merged

Replace local copyright check with pre-commit-hooks verify-copyright #5732

merged 12 commits into from
Mar 12, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jan 29, 2024 •
edited
Loading

The local copyright.py script is bug-prone. Replace it with a more robust centralized script from pre-commit-hooks.

Issue: rapidsai/build-planning#30

@KyleFromNVIDIA
Replace local copyright check with pre-commit-hooks verify-copyright
beeafdd 
And get all existing files up to date with --batch.
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners January 29, 2024 16:20
@github-actions github-actions bot added conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ ci labels Jan 29, 2024
@KyleFromNVIDIA KyleFromNVIDIA added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 29, 2024
@github-actions github-actions bot removed conda conda issue Cython / Python Cython or Python issue CMake CUDA/C++ ci labels Jan 30, 2024
@github-actions github-actions bot added the ci label Jan 30, 2024
@bdice bdice removed request for a team March 11, 2024 21:14
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c52ca52 into rapidsai:branch-24.04 Mar 12, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
2 - In Progress Currenty a work in progress ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleFromNVIDIA @bdice @AyodeAwe