Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GDS with public package for v0.19.0 #3

Closed
gigony opened this issue Apr 12, 2021 · 1 comment · Fixed by #106
Closed

Enable GDS with public package for v0.19.0 #3

gigony opened this issue Apr 12, 2021 · 1 comment · Fixed by #106
Assignees
@gigony
Labels
feature request New feature or request
Milestone
v21.10

Comments

@gigony
Copy link
Contributor

gigony commented Apr 12, 2021

GDS feature is disabled for now due to no public cuFile package available.
Once GDS package is released publicly(expected to release this week), need to update the code to use cufile.h header from the public package and/or update conda package to use the public gds package.
@gigony gigony added the improvement Improves an existing functionality label Apr 12, 2021
@gigony gigony self-assigned this Apr 12, 2021
@gigony gigony mentioned this issue Apr 12, 2021
Merged
@benjha
Copy link

benjha commented Jul 8, 2021 •
edited
Loading

Please, provide mechanisms to turning on/off GDS.

See #64 for context.

@gigony gigony added feature request New feature or request and removed improvement Improves an existing functionality labels Sep 7, 2021
@gigony gigony modified the milestones: v21.09, v21.10, v21.08.02 Sep 7, 2021
@gigony gigony mentioned this issue Sep 28, 2021
Merged
@rapids-bot rapids-bot bot closed this as completed in #106 Sep 29, 2021
rapids-bot bot pushed a commit that referenced this issue Sep 29, 2021
@gigony
Enable GDS and Support Runtime Context (__enter__, __exit__) for CuFi…
68f6042 
…leDriver and CuImage (#106)

- Enable GDS with GDS v1.0.0
  - Re-enable GDS with public package
  - Found an issue with a GDS static library and working on WSL
    1. Segmentation fault error is happening if we link GDS static library because GDS static library file (libcufile.a) available does not support non-CXX11 ABI (`-D_GLIBCXX_USE_CXX11_ABI=0`).  Python wheel with manylinux2014 needs to be compiled with non-CXX ABI
        - Workaround the static library issue by using a shared library (if exists on the system) instead.
    2. Loading/using GDS shared library(libcufile.so) causes `Assertion failure, file index :cufio-udev  line :143` error on WSL
        - Workaround the WSL issue by not loading GDS shared library (calling `cuFileDriverOpen()`) if the platform is WSL.
- Do not use GDS if in WSL
- Add `__enter__` and `__exit__` for CuFileDriver
- Add `__enter__` and `__exit__` for CuImage


Resolves #3

Authors:
  - Gigon Bae (https://github.com/gigony)

Approvers:
  - https://github.com/jakirkham

URL: #106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gigony gigony

Labels
feature request New feature or request
Projects
None yet
Milestone
v21.10
2 participants
@gigony @benjha