Fix bug in median filter with non-uniform footprint #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity This caused e.g. cucim.skimage.median to not work if a non-square footprint was provided
grlee77
added
bug
jakirkham
approved these changes
Feb 28, 2023
jakirkham
reviewed
Feb 28, 2023
jakirkham
approved these changes
Feb 28, 2023
jakirkham
approved these changes
Mar 8, 2023
|
/merge |
|
Thanks Greg! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #520
#485 Introduced a bug in rank filtering kernels that was not caught by our current test cases
(so this bug is only present in the 23.02 release)
This MR fixes the bug and adds test coverage for this case.