Skip to content

Commit

Permalink
Remove supports_streams from cuDF custom memory resources. (#14857)
Browse files Browse the repository at this point in the history
Part of rapidsai/rmm#1389. This removes now-optional and soon-to-be deprecated `supports_streams()` from cuDF's custom `device_memory_resource` implementations.

Depends on rapidsai/rmm#1437

Authors:
  - Mark Harris (https://github.com/harrism)
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Bradley Dice (https://github.com/bdice)
  - Yunsong Wang (https://github.com/PointKernel)
  - Michael Schellenberger Costa (https://github.com/miscco)

URL: #14857
  • Loading branch information
harrism committed Jan 26, 2024
1 parent a41238f commit b47f5ee
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
7 changes: 0 additions & 7 deletions cpp/include/cudf_test/stream_checking_resource_adaptor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,6 @@ class stream_checking_resource_adaptor final : public rmm::mr::device_memory_res
*/
Upstream* get_upstream() const noexcept { return upstream_; }

/**
* @brief Checks whether the upstream resource supports streams.
*
* @return Whether or not the upstream resource supports streams
*/
bool supports_streams() const noexcept override { return upstream_->supports_streams(); }

private:
/**
* @brief Allocates memory of size at least `bytes` using the upstream
Expand Down
4 changes: 0 additions & 4 deletions java/src/main/native/src/RmmJni.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ class tracking_resource_adaptor final : public base_tracking_resource_adaptor {
return scoped_max_total_allocated;
}

bool supports_streams() const noexcept override { return resource->supports_streams(); }

private:
Upstream *const resource;
std::size_t const size_align;
Expand Down Expand Up @@ -207,8 +205,6 @@ class java_event_handler_memory_resource : public device_memory_resource {

device_memory_resource *get_wrapped_resource() { return resource; }

bool supports_streams() const noexcept override { return resource->supports_streams(); }

private:
device_memory_resource *const resource;
base_tracking_resource_adaptor *const tracker;
Expand Down

0 comments on commit b47f5ee

Please sign in to comment.