Make device_memory_resource::supports_streams() not pure virtual. Remove derived implementations and calls in RMM #1437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
wence-
approved these changes
Jan 25, 2024
| @@ -299,7 +299,7 @@ class device_memory_resource { | |||
| * | |||
| * @returns bool true if the resource supports non-null CUDA streams. | |||
| */ | |||
| [[nodiscard]] virtual bool supports_streams() const noexcept = 0; | |||
| [[nodiscard]] virtual bool supports_streams() const noexcept { return false; } | |||
There was a problem hiding this comment.
question (non-blocking): This remains virtual so that downstream users don't immediately break? (I must admit that inheritance in C++ is not one of my strong suits)
There was a problem hiding this comment.
Exactly. And it's being deprecated as soon as the two downstream PRs (already approved) merge. Then removed in the next release. Nobody uses this, and it's not part of cuda::mr::async_memory_resource
|
"Pure virtual" means that there is no implementation in the base class. Corrected PR title. |
harrism
changed the title
miscco
approved these changes
Jan 26, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jan 26, 2024
Part of rapidsai/rmm#1389. This removes now-optional and soon-to-be deprecated `supports_streams()` from cuDF's custom `device_memory_resource` implementations. Depends on rapidsai/rmm#1437 Authors: - Mark Harris (https://github.com/harrism) - Bradley Dice (https://github.com/bdice) Approvers: - Nghia Truong (https://github.com/ttnghia) - Bradley Dice (https://github.com/bdice) - Yunsong Wang (https://github.com/PointKernel) - Michael Schellenberger Costa (https://github.com/miscco) URL: #14857
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1432. Part of #1389
Checklist