Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Not 100% accurate statement in 10 min to cuDF and CuPy #7160

Closed
miguelusque opened this issue Jan 12, 2021 · 1 comment · Fixed by #7158
Closed

[DOC] Not 100% accurate statement in 10 min to cuDF and CuPy #7160

miguelusque opened this issue Jan 12, 2021 · 1 comment · Fixed by #7158
Labels
doc Documentation

Comments

@miguelusque
Copy link
Member

Report incorrect documentation

Hi!

I think the following paragraph is not 100% accurate:

Because CuPy arrays have a single dtype, each column in our DataFrame must have the same dtype, regardless of which method we use.

The following code works just fine:

import cudf
import cupy

df = cudf.DataFrame({'a': 3, 'b': 3.0})
arr = cupy.asarray(df.as_gpu_matrix())

In the example above, int datatypes as casted to float64.

Hope it helps!
Miguel

Location of incorrect documentation
https://github.com/rapidsai/docs/blob/gh-pages/api/cudf/0.18/10min-cudf-cupy.ipynb

@ajschmidt8 ajschmidt8 transferred this issue from rapidsai/docs Jan 15, 2021
@ajschmidt8
Copy link
Member

@miguelusque, the documentation you mentioned is automatically generated from cudf's source files, so I've transferred your issue into the cudf repo.

@ajschmidt8 ajschmidt8 added the doc Documentation label Jan 15, 2021
@rapids-bot rapids-bot bot closed this as completed in #7158 Feb 5, 2021
rapids-bot bot pushed a commit that referenced this issue Feb 5, 2021
This updates the 10 minutes to cuDF and CuPY notebook to use the new methods for moving between cuDF data structures and CuPy arrays.

Closes #7160

Authors:
  - @ChrisJar

Approvers:
  - Ashwin Srinath (@shwina)

URL: #7158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation
Projects
None yet
2 participants