Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] First reduction produces incorrect result type for inputs of list_type #9758

Closed
sperlingxx opened this issue Nov 23, 2021 · 0 comments · Fixed by #9759
Closed

[BUG] First reduction produces incorrect result type for inputs of list_type #9758

sperlingxx opened this issue Nov 23, 2021 · 0 comments · Fixed by #9759
Assignees
@sperlingxx
Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
Bug Squashing

Comments

@sperlingxx
Copy link
Contributor

Describe the bug
The column view of return scalar is in list_type rather than the child type of the input list_type. It is because in make_empty_scalar_like we create list scalar with the list column instead of its child.
@sperlingxx sperlingxx added bug Something isn't working Needs Triage Need team to review and classify labels Nov 23, 2021
@sperlingxx sperlingxx self-assigned this Nov 23, 2021
@github-actions github-actions bot added this to Needs prioritizing in Bug Squashing Nov 23, 2021
@sperlingxx sperlingxx mentioned this issue Nov 23, 2021
Merged
@harrism harrism added the libcudf Affects libcudf (C++/CUDA) code. label Nov 24, 2021
@rapids-bot rapids-bot bot closed this as completed in #9759 Dec 2, 2021
Bug Squashing automation moved this from Needs prioritizing to Closed Dec 2, 2021
rapids-bot bot pushed a commit that referenced this issue Dec 2, 2021
@sperlingxx
Fix make_empty_scalar_like on list_type (#9759)
c10966c 
Fixes #9758

In `make_empty_scalar_like`, we create list scalar with the list column itself, which is wrong. The correct way is with the child of list column.

Authors:
  - Alfred Xu (https://github.com/sperlingxx)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)
  - Devavret Makkar (https://github.com/devavret)

URL: #9759
@bdice bdice removed the Needs Triage Need team to review and classify label Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
bug Something isn't working libcudf Affects libcudf (C++/CUDA) code.
Projects
No open projects
Bug Squashing
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix make_empty_scalar_like on list_type sperlingxx/cudf
3 participants
@harrism @bdice @sperlingxx