Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Upgrade arrow-cpp & pyarrow to 7.0.0 #10503

Merged
merged 7 commits into from
Apr 1, 2022
Merged

[REVIEW] Upgrade arrow-cpp & pyarrow to 7.0.0 #10503

merged 7 commits into from
Apr 1, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR upgrades arrow-cpp & pyarrow to 7.0.0 from 6.0.1

@galipremsagar galipremsagar added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 23, 2022
@galipremsagar galipremsagar self-assigned this Mar 23, 2022
@galipremsagar galipremsagar requested review from a team as code owners March 23, 2022 23:32
@github-actions github-actions bot added CMake CMake build issue conda libcudf Affects libcudf (C++/CUDA) code. and removed Python Affects Python cuDF API. labels Mar 23, 2022
@galipremsagar galipremsagar mentioned this pull request Mar 24, 2022
Merged
@github-actions github-actions bot added the gpuCI label Mar 24, 2022
@galipremsagar galipremsagar added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 24, 2022
@jjacobelli
Copy link
Contributor

rerun tests

2 similar comments
@jjacobelli
Copy link
Contributor

rerun tests

@jjacobelli
Copy link
Contributor

rerun tests

@codecov
Copy link

codecov bot commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #10503 (b3516d0) into branch-22.06 (73bc7d7) will not change coverage.
The diff coverage is n/a.

❗ Current head b3516d0 differs from pull request most recent head 3b0ef6c. Consider uploading reports for the commit 3b0ef6c to get more accurate results

@@              Coverage Diff              @@
##           branch-22.06   #10503   +/-   ##
=============================================
  Coverage         86.33%   86.33%           
=============================================
  Files               140      140           
  Lines             22300    22300           
=============================================
  Hits              19253    19253           
  Misses             3047     3047

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca952f8...3b0ef6c. Read the comment docs.

@galipremsagar galipremsagar removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Mar 29, 2022
galipremsagar
galipremsagar commented Mar 29, 2022
View reviewed changes
ci/gpu/java.sh Outdated Show resolved Hide resolved
galipremsagar
galipremsagar commented Mar 29, 2022
View reviewed changes
ci/gpu/build.sh Outdated Show resolved Hide resolved
galipremsagar
galipremsagar commented Mar 29, 2022
View reviewed changes
ci/cpu/build.sh Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the gpuCI label Mar 29, 2022
@galipremsagar
Copy link
Contributor Author

rerun tests

3 similar comments
@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@jakirkham jakirkham mentioned this pull request Apr 1, 2022
Merged
@jakirkham
Copy link
Member

Do we know what caused the failure? Can only spot ninja: build stopped: subcommand failed., which isn't particularly illuminating. Was there a compile error somewhere that I'm missing? If not, is this some kind of hardware oversubscription issue?

@galipremsagar
Copy link
Contributor Author

Do we know what caused the failure? Can only spot ninja: build stopped: subcommand failed., which isn't particularly illuminating. Was there a compile error somewhere that I'm missing? If not, is this some kind of hardware oversubscription issue?

The compilation errors are due to mix of arrow versions because 22.04 images are being picked up. @ajschmidt8 is working on resolving it.

@jakirkham
Copy link
Member

rerun tests

ajschmidt8
ajschmidt8 approved these changes Apr 1, 2022
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Apr 1, 2022
@jakirkham
Copy link
Member

@gpucibot merge

@galipremsagar
Copy link
Contributor Author

rerun tests

@rapids-bot rapids-bot bot merged commit 291fbcf into rapidsai:branch-22.06 Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@galipremsagar @jjacobelli @jakirkham @robertmaynard @ajschmidt8