Fix missing RMM_STATIC_CUDART define when compiling JNI with static CUDA runtime #10585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlowe
added
bug
abellina
approved these changes
Apr 4, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #10585 +/- ##
================================================
- Coverage 86.33% 86.33% -0.01%
================================================
Files 140 140
Lines 22300 22300
================================================
- Hits 19253 19252 -1
- Misses 3047 3048 +1
Continue to review full report at Codecov.
|
|
@gpucibot merge |
vyasr
added
4 - Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10571.
This fixes the JNI CMakeLists.txt so that RMM will automatically get the
RMM_STATIC_CUDARTdefine added to the build whenCUDA_STATIC_RUNTIME=ON. Verified by building with Javva CI Dockerfile with static CUDA runtime and examining the build command-lines and flag definitions in java/target/cmake-build/CMakeFiles.