Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ccache for cudfjni build in Docker #10790

Merged
merged 18 commits into from
May 5, 2022

Conversation

gerashegalov
Copy link
Contributor

This PR enables ccache support for ./build.sh clean cudfjar.

ccache 4.6 is built during image creation because ccacheversion available via yum install does not cache nvcc-compiled binaries.

It's enabled by default for build.sh and repeated no-change build

PARALLEL_LEVEL=6 SKIP_TESTS=true time ./build.sh clean cudfjar

succeeds in 1.5 min on my machine. To disable set CCACHE_DISABLE=1 in the environment

It's not enabled for ./java/ci/build-in-docker.sh

Signed-off-by: Gera Shegalov gera@apache.org

gerashegalov and others added 14 commits March 28, 2022 14:50
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Co-authored-by: Jason Lowe <jlowe@nvidia.com>
- and fix bug of CUDF_CPP_BUILD_DIR parameter being ignored

Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
Signed-off-by: Gera Shegalov <gera@apache.org>
@gerashegalov gerashegalov added 3 - Ready for Review Ready for review by team Spark Functionality that helps Spark RAPIDS 4 - Needs cuDF (Java) Reviewer non-breaking Non-breaking change labels May 4, 2022
@gerashegalov gerashegalov requested a review from a team as a code owner May 4, 2022 18:21
@gerashegalov gerashegalov self-assigned this May 4, 2022
@github-actions github-actions bot added the Java Affects Java cuDF API. label May 4, 2022
@gerashegalov gerashegalov added the improvement Improvement / enhancement to an existing function label May 4, 2022
java/ci/Dockerfile.centos7 Outdated Show resolved Hide resolved
java/ci/Dockerfile.centos7 Outdated Show resolved Hide resolved
java/pom.xml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #10790 (9b5ccfa) into branch-22.06 (8d861ce) will increase coverage by 0.04%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10790      +/-   ##
================================================
+ Coverage         86.40%   86.45%   +0.04%     
================================================
  Files               143      143              
  Lines             22448    22491      +43     
================================================
+ Hits              19396    19444      +48     
+ Misses             3052     3047       -5     
Impacted Files Coverage Δ
python/cudf/cudf/core/indexed_frame.py 91.70% <0.00%> (ø)
python/cudf/cudf/core/dataframe.py 93.77% <0.00%> (+0.08%) ⬆️
python/cudf/cudf/core/column/string.py 89.21% <0.00%> (+0.12%) ⬆️
python/cudf/cudf/core/groupby/groupby.py 91.79% <0.00%> (+0.22%) ⬆️
python/cudf/cudf/core/column/numerical.py 96.17% <0.00%> (+0.29%) ⬆️
python/cudf/cudf/core/tools/datetimes.py 84.49% <0.00%> (+0.30%) ⬆️
python/cudf/cudf/core/column/lists.py 92.91% <0.00%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d861ce...9b5ccfa. Read the comment docs.

java/ci/Dockerfile.centos7 Outdated Show resolved Hide resolved
Copy link
Member

@jlowe jlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a minor question about potentially simplifying a build line which is not crucial.

Co-authored-by: Jason Lowe <jlowe@nvidia.com>
@gerashegalov gerashegalov added the 5 - Ready to Merge Testing and reviews complete, ready to merge label May 5, 2022
@gerashegalov
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 14b5169 into rapidsai:branch-22.06 May 5, 2022
@gerashegalov gerashegalov deleted the ccache branch May 5, 2022 04:32
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Java) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond 5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants