Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Pin protobuf version #10996

Merged
merged 1 commit into from
May 31, 2022
Merged

[REVIEW] Pin protobuf version #10996

merged 1 commit into from
May 31, 2022

Conversation

galipremsagar
Copy link
Contributor

Fixes: #10990

This PR pins the protobuf version to the latest and chooses narrower pinning because of the lower likelihood of breaking API changes between minor patch versions as opposed to major version changes.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 27, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner May 27, 2022 16:44
@galipremsagar galipremsagar self-assigned this May 27, 2022
@galipremsagar galipremsagar requested a review from a team as a code owner May 27, 2022 16:44
@github-actions github-actions bot added the conda label May 27, 2022
@galipremsagar galipremsagar mentioned this pull request May 27, 2022
Merged
@codecov
Copy link

codecov bot commented May 27, 2022 •
edited
Loading

Codecov Report

Merging #10996 (d8d6198) into branch-22.06 (0a34f67) will increase coverage by 0.22%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06   #10996      +/-   ##
================================================
+ Coverage         86.32%   86.54%   +0.22%     
================================================
  Files               144      144              
  Lines             22688    23364     +676     
================================================
+ Hits              19585    20220     +635     
- Misses             3103     3144      +41
Impacted Files Coverage Δ
python/dask_cudf/dask_cudf/backends.py 85.52% <0.00%> (+0.90%) ⬆️
python/cudf/cudf/core/column/column.py 90.79% <0.00%> (+1.01%) ⬆️
python/cudf/cudf/core/column/categorical.py 90.78% <0.00%> (+1.41%) ⬆️
python/cudf/cudf/core/buffer.py 91.06% <0.00%> (+2.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a34f67...d8d6198. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar galipremsagar changed the base branch from branch-22.08 to branch-22.06 May 27, 2022 21:04
@galipremsagar
Copy link
Contributor Author

rerun tests

@pxLi pxLi mentioned this pull request May 30, 2022
Closed
@ajschmidt8 ajschmidt8 merged commit d0b4e30 into rapidsai:branch-22.06 May 31, 2022
@vyasr vyasr added 4 - Needs Review Waiting for reviewer to review or respond and removed 4 - Needs cuDF (Python) Reviewer labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@skirui-source skirui-source Awaiting requested review from skirui-source skirui-source is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@shwina shwina Awaiting requested review from shwina

Assignees

@galipremsagar galipremsagar

Labels
3 - Ready for Review Ready for review by team 4 - Needs Review Waiting for reviewer to review or respond improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] incompatible protobuf dep version when installing cudf
3 participants
@galipremsagar @ajschmidt8 @vyasr