Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type promotion edge cases in numerical binops #12074

Merged
merged 15 commits into from
Nov 16, 2022
Merged

Fix type promotion edge cases in numerical binops #12074

merged 15 commits into from
Nov 16, 2022

Commits on Nov 8, 2022

  1. Be more careful in type promotion for scalar binop 

    Try and do everything following numpy using types rather than values
by first attempting to use the dtype of the passed in operand and
subsequently (if it does not have one) using result_type. This way
we avoid problems with min_scalar_type wanting to pick unsigned int
types for bare Python integers.
    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    d670394 View commit details
    Browse the repository at this point in the history

  2. Be even more careful promoting types

    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    b5dd7b1 View commit details
    Browse the repository at this point in the history

  3. Check for zero cudf.Scalar in __floordiv__ and __mod__ 

    Closes rapidsai#12092.
    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    e3f50dc View commit details
    Browse the repository at this point in the history

  4. Fix check for zero with columns in __floordiv__ and __mod__ 

    Closes rapidsai#5938.
    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    77d94d1 View commit details
    Browse the repository at this point in the history

  5. Test division by zero with Series as well

    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    603fdbb View commit details
    Browse the repository at this point in the history

  6. Handle NA cudf.Scalar in div by zero check

    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    f023aea View commit details
    Browse the repository at this point in the history

  7. xfail floordiv/mod by zero bool 

    No idea how to handle the pandas weirdness here.
    @wence-
    wence- committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    33aae16 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2022

  1. Need to manually promote when constructing microsecond 

    Now that binop with cudf.Scalar matches pandas behaviour with
numpy-dtype-enabled scalars, we need to manually promote here.
    @wence-
    wence- committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    778bfd3 View commit details
    Browse the repository at this point in the history

  2. Remove dead code

    @wence-
    wence- committed Nov 9, 2022
    Configuration menu
    Copy the full SHA
    8b2577a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2022

  1. Use is_valid to check for non-Null Scalar

    @wence-
    wence- committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    1b4da9b View commit details
    Browse the repository at this point in the history

  2. timedelta: __floordiv__ doesn't cast to float

    @wence-
    wence- committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    0e76023 View commit details
    Browse the repository at this point in the history

  3. Remove xfails related to rapidsai#5938

    @wence-
    wence- committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    f06a6b9 View commit details
    Browse the repository at this point in the history

  4. Remove xfails related to pandas-dev/pandas#35529

    @wence-
    wence- committed Nov 11, 2022
    Configuration menu
    Copy the full SHA
    5af7e63 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2022

  1. Promote type in DateTimeIndex.microsecond as well

    @wence-
    wence- committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    e55c9f0 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. Merge remote-tracking branch 'origin/branch-22.12' into wence/fix/iss… 

    …ue-12072
    @wence-
    wence- committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    56cd889 View commit details
    Browse the repository at this point in the history