-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix construction of Grouping
objects
#13932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
commented
Aug 22, 2023
galipremsagar
added
bug
Something isn't working
non-breaking
Non-breaking change
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Python) Reviewer
labels
Aug 23, 2023
wence-
requested changes
Aug 23, 2023
wence-
approved these changes
Aug 23, 2023
Serialization test looks like it fails https://github.com/rapidsai/cudf/actions/runs/5953195610/job/16147414724?pr=13932 |
Fixed it 👍 |
bdice
approved these changes
Aug 23, 2023
galipremsagar
removed
3 - Ready for Review
Ready for review by team
4 - Needs cuDF (Python) Reviewer
labels
Aug 23, 2023
galipremsagar
added
the
5 - Ready to Merge
Testing and reviews complete, ready to merge
label
Aug 23, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
bug
Something isn't working
non-breaking
Non-breaking change
Python
Affects Python cuDF API.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes multiple issues with groupby where the consequent operations on a groupby object always return incorrect results due to an inplace modification that happens in the
Groupby
constructor. To fix this, take a copy of theby
argument whenever it is an (internal)_Grouping
object..cumcount
#13390Checklist