Add pandas compatible output to Series.unique
#13959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
3 - Ready for Review
wence-
approved these changes
Aug 25, 2023
| @@ -2970,6 +2970,8 @@ def unique(self): | |||
| dtype: object | |||
| """ | |||
| res = self._column.unique() | |||
| if cudf.get_option("mode.pandas_compatible"): | |||
| return res.values | |||
| return Series(res, name=self.name) | |||
There was a problem hiding this comment.
Only doing this in pandas-compat mode because this marks the buffer as exposed, and may not work for string/struct types?
There was a problem hiding this comment.
Yup, will only work for numeric types (int, float..) and error for the rest of the types.
galipremsagar
added
improvement
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially addresses #8175
This PR makes changes to
Series.unique, where a cupy array is returned to matchpd.Series.uniquewhere a numpy array is returned.Checklist