-
Notifications
You must be signed in to change notification settings - Fork 883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memset error in nvtext::edit_distance_matrix #14283
Fix memset error in nvtext::edit_distance_matrix #14283
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Would we want to consider a using ...
type declaration, or decltype
, or rmm::device_uvector<T>::value_type
, or something to reduce the hardcoded types?
I'm not sure it is worth doing. Every parameter to
and realized that I could just have easily put in the wrong |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like something that the compiler can detect and issue a warning :)
/merge |
Description
Fixes a bug in
nvtext::edit_distance_matrix
where the internal offsets vector is initialized to 0.This error was introduced in #13912
The bug was found while working on a different PR which re-ordered the nvtext gtests execution causing device memory to be reused from the rmm pool in a different way.
Checklist