Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isinstance(..., cudf.IntervalDtype) instead of is_interval_dtype #14424

Merged
merged 9 commits into from
Dec 8, 2023
Merged

Use isinstance(..., cudf.IntervalDtype) instead of is_interval_dtype #14424

merged 9 commits into from
Dec 8, 2023

Conversation

mroeschke
Copy link
Contributor

Helps the code base be more-strict about checking cudf.IntervalDtype and not accidentally allowing pd.IntervalDtype or "interval"

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 16, 2023
@mroeschke mroeschke requested a review from a team as a code owner November 16, 2023 03:04
@mroeschke mroeschke changed the title REF: Use isinstance(..., cudf.IntervalDtype) instead of is_interval_dtype Use isinstance(..., cudf.IntervalDtype) instead of is_interval_dtype Nov 28, 2023
@mroeschke
Copy link
Contributor Author

/merge

@mroeschke
Copy link
Contributor Author

/merge

1 similar comment
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 016cf1e into rapidsai:branch-24.02 Dec 8, 2023
68 checks passed
@mroeschke mroeschke deleted the ref/is_interval_dtype branch December 8, 2023 22:27
karthikeyann pushed a commit to karthikeyann/cudf that referenced this pull request Dec 12, 2023
@mroeschke @karthikeyann
Use isinstance(..., cudf.IntervalDtype) instead of is_interval_dtype (r…
ad13b42 
…apidsai#14424)

Helps the code base be more-strict about checking cudf.IntervalDtype and not accidentally allowing pd.IntervalDtype or "interval"

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)

Approvers:
  - GALI PREM SAGAR (https://github.com/galipremsagar)

URL: rapidsai#14424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @galipremsagar