Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check column type equality, handling nested types correctly. #14531

Merged
merged 39 commits into from
May 2, 2024
Merged

Check column type equality, handling nested types correctly. #14531

merged 39 commits into from
May 2, 2024

Commits on Mar 11, 2024

  1. Check column types with a utility that handles nesting correctly.

    @bdice
    bdice committed Mar 11, 2024
    Configuration menu
    Copy the full SHA
    39d14c8 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge remote-tracking branch 'upstream/branch-24.04' into nested-colu… 

    …mn-type-checks
    @bdice
    bdice committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2e3979f View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge remote-tracking branch 'upstream/branch-24.06' into nested-colu… 

    …mn-type-checks
    @bdice
    bdice committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    57b3b50 View commit details
    Browse the repository at this point in the history

  2. Add column_scalar_types_equal.

    @bdice
    bdice committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    5f7f1f8 View commit details
    Browse the repository at this point in the history

  3. Use column_scalar_types_equal.

    @bdice
    bdice committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d880838 View commit details
    Browse the repository at this point in the history

  4. Fix bugs and update tests.

    @bdice
    bdice committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    8b152dc View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Add scalar_types_equal.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5cf4769 View commit details
    Browse the repository at this point in the history

  2. Fix tests.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8d938bb View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/branch-24.06' into nested-colu… 

    …mn-type-checks
    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    f7d8c41 View commit details
    Browse the repository at this point in the history

  4. Add data_type_errors.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    5430397 View commit details
    Browse the repository at this point in the history

  5. Fix tests.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8e02603 View commit details
    Browse the repository at this point in the history

  6. Fix remaining type checks that should use new utilities.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    a1bbecb View commit details
    Browse the repository at this point in the history

  7. Add docs section on comparing data types.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0de9f9b View commit details
    Browse the repository at this point in the history

  8. Fix typo.

    @bdice
    bdice committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    fc7b821 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2024

  1. Merge remote-tracking branch 'upstream/branch-24.06' into nested-colu… 

    …mn-type-checks
    @bdice
    bdice committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    55e0c9f View commit details
    Browse the repository at this point in the history

  2. Use cudf::is_fixed_point. 

    Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
    @bdice @davidwendt
    bdice and davidwendt authored Apr 1, 2024
    Configuration menu
    Copy the full SHA
    faa92c8 View commit details
    Browse the repository at this point in the history

  3. Fix missing paren.

    @bdice
    bdice committed Apr 1, 2024
    Configuration menu
    Copy the full SHA
    6556266 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. list column, not lists column 

    Co-authored-by: Lawrence Mitchell <wence@gmx.li>
    @bdice @wence-
    bdice and wence- authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    6531a53 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Rename functions to be overloads of cudf::types_equal, update and exp… 

    …and tests.
    @bdice
    bdice committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    454d413 View commit details
    Browse the repository at this point in the history

  2. Rename function.

    @bdice
    bdice committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    c91df10 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Rename to have_same_types, apply PR feedback.

    @bdice
    bdice committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    c742253 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/branch-24.06' into nested-colu… 

    …mn-type-checks
    @bdice
    bdice committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    8a44004 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Add back deprecated methods.

    @bdice
    bdice committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    fce091f View commit details
    Browse the repository at this point in the history

  2. Fix verb/subject agreement.

    @bdice
    bdice committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cafdf6f View commit details
    Browse the repository at this point in the history

  3. Update docs for all_have_same_types. 

    Co-authored-by: Lawrence Mitchell <wence@gmx.li>
    @bdice @wence-
    bdice and wence- authored Apr 12, 2024
    Configuration menu
    Copy the full SHA
    cda4e0d View commit details
    Browse the repository at this point in the history

  4. Un-deprecate column_types_equivalent.

    @bdice
    bdice committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ec740c9 View commit details
    Browse the repository at this point in the history

  5. Apply patch from Lawrence.

    @bdice
    bdice committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    ec0eeff View commit details
    Browse the repository at this point in the history

  6. Use std::equal.

    @bdice
    bdice committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    5afc5e2 View commit details
    Browse the repository at this point in the history

  7. Switch back to column_types_equivalent.

    @bdice
    bdice committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    18cdd52 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2024

  1. Fix tests that had incorrect nested types.

    @bdice
    bdice committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    7c05d95 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'nested-column-type-checks' of github.com:bdice/cudf int… 

    …o nested-column-type-checks
    @bdice
    bdice committed Apr 13, 2024
    Configuration menu
    Copy the full SHA
    7ba2664 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge remote-tracking branch 'upstream/branch-24.06' into nested-colu… 

    …mn-type-checks
    @bdice
    bdice committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9904431 View commit details
    Browse the repository at this point in the history

  2. Fix clang-format.

    @bdice
    bdice committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    15d05e0 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. Move table_view overload from table_view.hpp to type_checks.hpp.

    @bdice
    bdice committed May 1, 2024
    Configuration menu
    Copy the full SHA
    57c1f64 View commit details
    Browse the repository at this point in the history

  2. Mirror scalar/column call. 

    Co-authored-by: Lawrence Mitchell <wence@gmx.li>
    @bdice @wence-
    bdice and wence- authored May 1, 2024
    Configuration menu
    Copy the full SHA
    25c5ad9 View commit details
    Browse the repository at this point in the history

  3. Minor cleanup.

    @bdice
    bdice committed May 1, 2024
    Configuration menu
    Copy the full SHA
    d764f7e View commit details
    Browse the repository at this point in the history

  4. Improve dispatching to existing overloads.

    @bdice
    bdice committed May 1, 2024
    Configuration menu
    Copy the full SHA
    e0732b9 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'nested-column-type-checks' of github.com:bdice/cudf int… 

    …o nested-column-type-checks
    @bdice
    bdice committed May 1, 2024
    Configuration menu
    Copy the full SHA
    fc0dada View commit details
    Browse the repository at this point in the history

  6. Merge branch 'branch-24.06' into nested-column-type-checks

    @bdice
    bdice authored May 1, 2024
    Configuration menu
    Copy the full SHA
    32444c5 View commit details
    Browse the repository at this point in the history