Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop nvbench patch for nvml. #14631

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Drop nvbench patch for nvml. #14631

merged 1 commit into from
Dec 15, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 14, 2023

Description

We can drop a patch from nvbench for nvml support now that it has been upstreamed and dropped from rapids-cmake. rapidsai/rapids-cmake#488

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner December 14, 2023 16:52
@bdice bdice self-assigned this Dec 14, 2023
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 14, 2023
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Dec 14, 2023
@bdice
Copy link
Contributor Author

bdice commented Dec 15, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0762fbe into rapidsai:branch-24.02 Dec 15, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@bdice bdice

Labels
CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @robertmaynard