Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use as_column instead of arange for range like inputs #14689

Merged
merged 7 commits into from
Jan 12, 2024
Merged

Use as_column instead of arange for range like inputs #14689

merged 7 commits into from
Jan 12, 2024

Conversation

mroeschke
Copy link
Contributor

Description

  1. Allows range-like inputs in as_column to short circuit and not materialize when creating columns
  2. Avoids diverging column construction logic between column.arange and column.as_column

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 30, 2023
@mroeschke mroeschke requested a review from a team as a code owner December 30, 2023 01:23
@mroeschke mroeschke mentioned this pull request Jan 3, 2024
Merged
3 tasks
vyasr
vyasr reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The arange removal looks good, just trying to understand one thing before approving.

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 7a42b8b into rapidsai:branch-24.02 Jan 12, 2024
68 checks passed
@mroeschke mroeschke deleted the ref/as_column/range branch January 12, 2024 02:14
This was referenced Jan 12, 2024
Closed
Closed
@AjayThorve AjayThorve mentioned this pull request Jan 12, 2024
Merged
rapids-bot bot pushed a commit to rapidsai/cuspatial that referenced this pull request Jan 13, 2024
@AjayThorve
Update usage of cudf.core.column.arange to cudf.core.column.as_column (…
9b2b723 
…#1323)

This PR fixes failures which were caused becuase cuspatial uses an internal method of cudf that was removed in rapidsai/cudf#14689. The errors can be fixed by replacing those usages in the same fashion as was done internally in that cudf PR.

cc @vyasr

Authors:
  - Ajay Thorve (https://github.com/AjayThorve)

Approvers:
  - Michael Wang (https://github.com/isVoid)

URL: #1323
@wence- wence- mentioned this pull request Feb 26, 2024
Merged
3 tasks
rapids-bot bot pushed a commit that referenced this pull request Mar 5, 2024
@mroeschke
Use as_column instead of full (#14698)
3571291 
Similar to #14689, ensures there's 1 entrypoint to create a column from a scalar.

This builds on #14620

Authors:
  - Matthew Roeschke (https://github.com/mroeschke)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Richard (Rick) Zamora (https://github.com/rjzamora)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #14698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@charlesbluca charlesbluca Awaiting requested review from charlesbluca charlesbluca is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF/Dask/Numba/UCX
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr