Add support for axis=None in reductions #16229
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matt711
added
feature request
Matt711
commented
Jul 10, 2024
| return getattr(concat_columns(source._data.columns), op)( | ||
| **kwargs | ||
| ) | ||
| elif axis == 2 and op in {"std", "var"}: |
There was a problem hiding this comment.
How should std and var reductions be treated? I think 1. is right, but I wanted to check.
- Combine the columns, then compute the reduction
- Compute the reduction over columns, then compute the reduction again over those results
cc. @mroeschke, @vyasr
There was a problem hiding this comment.
In regards to 1, we do have to keep this comment in mind: #14930 (comment)
In terms of correctness, I forgot if std and var validate the minimum number of elements in the columns, but if so, the logic for axis=None should be something like.
if self.size < minimum_std_var_elements: Return NAif len(self) < minimum_std_var_elements and self.size > minimum_std_var_elements: Your option 1else: Your option 2
|
TODO: Check if this is still relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #12335
Checklist