Make ListColumn.__init__ strict #16465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
Python
bdice
reviewed
Aug 1, 2024
| ): | ||
| if data is not None: |
There was a problem hiding this comment.
I see you want this to have the same signature as the base class. What does that actually get us? Does it help with dispatching somewhere?
More broadly, is there an issue tracking all these refactorings and explaining why they are being pursued?
There was a problem hiding this comment.
Sorry I added some context during today's meeting but you're right that I should probably be creating an issue for these themed PRs. I added some color in #16469
bdice
reviewed
Aug 1, 2024
| if not ( | ||
| len(children) == 2 | ||
| and isinstance(children[0], NumericalColumn) | ||
| # TODO: Enforce unsigned integers? |
There was a problem hiding this comment.
libcudf uses size_type for offsets, which is defined as int32_t (it is signed).
bdice
approved these changes
Aug 17, 2024
|
/merge |
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Aug 20, 2024
A recent API change in cudf (rapidsai/cudf#16465) now requires the `data` argument to be passed (consistent with the other Column subclasses) Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Rick Ratzel (https://github.com/rlratzel) URL: #4620
3 tasks
rapids-bot bot
pushed a commit
to rapidsai/cuspatial
that referenced
this pull request
Aug 21, 2024
Post rapidsai/cudf#16465, the `data` argument to `ListColumn` is a required argument (as `None`) Authors: - Matthew Roeschke (https://github.com/mroeschke) Approvers: - Bradley Dice (https://github.com/bdice) URL: #1442
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes
ListColumn.__init__strict putting restrictions on data, dtype, size and children so these columns cannot be constructed into to an invalid state. It also aligns the signature with the base class.xref #16469
Checklist