Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Natively export __cuda_array_interface__ for Series/Index/Column objects #2464

Merged
merged 11 commits into from
Aug 13, 2019
Merged

[REVIEW] Natively export __cuda_array_interface__ for Series/Index/Column objects #2464

merged 11 commits into from
Aug 13, 2019

Conversation

kkraus14
Copy link
Collaborator

@kkraus14 kkraus14 commented Aug 4, 2019

Fixes #2433

Initial implementation and tests for natively exporting `__cuda_array…
5f4a179 
…_interface__` in Series/Index/Column objects
@kkraus14 kkraus14 added 2 - In Progress Currently a work in progress Python Affects Python cuDF API. labels Aug 4, 2019
@kkraus14 kkraus14 requested a review from a team as a code owner August 4, 2019 06:08
@kkraus14 kkraus14 self-assigned this Aug 4, 2019
@mrocklin mrocklin mentioned this pull request Aug 6, 2019
Closed
kkraus14
kkraus14 commented Aug 13, 2019
View reviewed changes
python/cudf/cudf/dataframe/columnops.py Outdated

mask = desc["mask"]
if mask is not None:
mask_ptr = mask.__cuda_array_interface__["data"][0]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't assume the mask is a bitmask here, it could be a boolean mask so you'd need to handle that differently.

@codecov
Copy link

codecov bot commented Aug 13, 2019 •
edited
Loading

Codecov Report

Merging #2464 into branch-0.9 will increase coverage by 0.05%.
The diff coverage is 93.1%.

Impacted file tree graph

@@              Coverage Diff               @@
##           branch-0.9    #2464      +/-   ##
==============================================
+ Coverage       83.42%   83.47%   +0.05%     
==============================================
  Files              56       56              
  Lines            8746     8798      +52     
==============================================
+ Hits             7296     7344      +48     
- Misses           1450     1454       +4
Impacted Files Coverage Δ
python/cudf/cudf/dataframe/series.py 93.01% <100%> (+0.01%) ⬆️
python/cudf/cudf/dataframe/string.py 93.6% <100%> (+0.03%) ⬆️
python/cudf/cudf/dataframe/index.py 88.83% <70%> (-0.48%) ⬇️
python/cudf/cudf/dataframe/columnops.py 88.33% <97.72%> (+1.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2fe47b...9118c66. Read the comment docs.

@kkraus14 kkraus14 changed the title [WIP] Natively export __cuda_array_interface__ for Series/Index/Column objects [REVIEW] Natively export __cuda_array_interface__ for Series/Index/Column objects Aug 13, 2019
@kkraus14 kkraus14 added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels Aug 13, 2019
dantegd
dantegd approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 13, 2019
@kkraus14 kkraus14 merged commit 307e924 into rapidsai:branch-0.9 Aug 13, 2019
@trivialfis trivialfis mentioned this pull request Aug 14, 2019
Merged
5 tasks
@shwina shwina mentioned this pull request Oct 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees

@kkraus14 kkraus14

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Export the __cuda_array_interface__ attribute
3 participants
@kkraus14 @dantegd @shwina