Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Fix return type of MultiIndex.argsort #5927

Merged
merged 8 commits into from
Aug 13, 2020

Conversation

galipremsagar
Copy link
Contributor

Fixes: #5923

This PR fixes the return type of MultiIndex.argsort which previously is a NumericalColumn and is now being changed to a cupy.array for consistency with Index.argsort/pd.Index.argsort .

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer labels Aug 11, 2020
@galipremsagar galipremsagar requested a review from a team as a code owner August 11, 2020 17:06
@galipremsagar galipremsagar self-assigned this Aug 11, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 11, 2020
@kkraus14
Copy link
Collaborator

rerun tests

3 similar comments
@galipremsagar
Copy link
Contributor Author

rerun tests

@kkraus14
Copy link
Collaborator

rerun tests

@galipremsagar
Copy link
Contributor Author

rerun tests

@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #5927 into branch-0.15 will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5927      +/-   ##
===============================================
+ Coverage        84.42%   84.44%   +0.02%     
===============================================
  Files               80       80              
  Lines            13424    13425       +1     
===============================================
+ Hits             11333    11337       +4     
+ Misses            2091     2088       -3     
Impacted Files Coverage Δ
python/cudf/cudf/core/index.py 92.83% <ø> (ø)
python/cudf/cudf/core/column/column.py 88.72% <100.00%> (ø)
python/cudf/cudf/core/dataframe.py 89.60% <100.00%> (+0.05%) ⬆️
python/cudf/cudf/core/multiindex.py 80.67% <100.00%> (+0.03%) ⬆️
python/cudf/cudf/core/abc.py 91.48% <0.00%> (+4.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e6b27...2170d05. Read the comment docs.

@kkraus14 kkraus14 merged commit e3e5b53 into rapidsai:branch-0.15 Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cudf.concat error due to index unmatch
4 participants