Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java unit tests for window aggregate 'collect' [skip ci] #7121

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Add Java unit tests for window aggregate 'collect' [skip ci] #7121

merged 5 commits into from
Feb 4, 2021

Conversation

firestarman
Copy link
Contributor

@firestarman firestarman commented Jan 12, 2021 •
edited
Loading

Add unit tests for aggregate 'collect' with windowing.

This PR depends on the PR #7189 .

Signed-off-by: Liangcai Li liangcail@nvidia.com

@firestarman firestarman requested a review from a team as a code owner January 12, 2021 06:57
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@jlowe jlowe marked this pull request as draft January 12, 2021 16:22
@jlowe jlowe changed the title [WIP] Add unit tests for aggregate 'collect'. Add Java unit tests for window aggregate 'collect' [skip ci] Jan 12, 2021
@jlowe jlowe added 2 - In Progress Currently a work in progress Java Affects Java cuDF API. tests Unit testing for project labels Jan 12, 2021
@jlowe jlowe added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 12, 2021
@jlowe
Copy link
Member

jlowe commented Jan 12, 2021

@firestarman I moved this PR to a draft. cudf recently changed to using draft PRs and/or labels to indicate the state of PRs rather than tags in the PR headline. AFAIK the only tag that should be in the headline is for skipping CI which is appropriate for Java-only PRs like this one.

@firestarman
Copy link
Contributor Author

@firestarman I moved this PR to a draft. cudf recently changed to using draft PRs and/or labels to indicate the state of PRs rather than tags in the PR headline. AFAIK the only tag that should be in the headline is for skipping CI which is appropriate for Java-only PRs like this one.

OK. Thanks.

mythrocks
mythrocks requested changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. The test is accurate.
I have left a couple of minor comments to sort out.

@firestarman
Add unit tests for aggregate 'collect'.
b94c016 
Add unit tests for aggregate 'collect' with windowing.

Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Address some comments
94ee4ce 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Remove the rmm log file
8e6a4b9 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Correct the index of the dummy data
bab8e45 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Copy link
Contributor Author

Looks good overall. The test is accurate.
I have left a couple of minor comments to sort out.

Thanks for review, and I have updated this PR per your comments.

@firestarman firestarman mentioned this pull request Jan 27, 2021
Closed
12 tasks
mythrocks
mythrocks reviewed Jan 28, 2021
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
java/src/test/java/ai/rapids/cudf/TableTest.java Show resolved Hide resolved
java/src/test/java/ai/rapids/cudf/TableTest.java Outdated Show resolved Hide resolved
@firestarman
Restore the gitignore file
bd748f0 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@mythrocks mythrocks marked this pull request as ready for review January 28, 2021 07:43
@mythrocks mythrocks marked this pull request as draft January 28, 2021 07:43
mythrocks
mythrocks approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@mythrocks mythrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This should go in after #7189.

@mythrocks mythrocks marked this pull request as ready for review January 30, 2021 00:41
@mythrocks
Copy link
Contributor

#7189 has been merged to branch-0.18.

I have moved this PR out of Draft. We'll wait for the tests to run.

@firestarman
Copy link
Contributor Author

#7189 has been merged to branch-0.18.

I have moved this PR out of Draft. We'll wait for the tests to run.

thanks

@mythrocks
Copy link
Contributor

rerun tests

@mythrocks mythrocks added 4 - Needs cuDF (Java) Reviewer and removed 2 - In Progress Currently a work in progress labels Feb 1, 2021
@firestarman
Copy link
Contributor Author

rerun tests

@mythrocks
Copy link
Contributor

For the record, I have addressed adding support for Spark null-handling semantics for COLLECT aggregations here:
#7264. I've put this up against branch-0.19.

@firestarman
Copy link
Contributor Author

For the record, I have addressed adding support for Spark null-handling semantics for COLLECT aggregations here:
#7264. I've put this up against branch-0.19.

Yes, i saw it. Thanks

@mythrocks mythrocks added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Feb 2, 2021
@mythrocks
Copy link
Contributor

mythrocks commented Feb 2, 2021 •
edited
Loading

@revans2, would you happen to know why the tests aren't running? I don't know if the PR will merge without the tests.
Argh, [skip ci], maybe.

@mythrocks mythrocks changed the title Add Java unit tests for window aggregate 'collect' [skip ci] Add Java unit tests for window aggregate 'collect' Feb 2, 2021
@mythrocks
Copy link
Contributor

rerun tests

@mythrocks
Copy link
Contributor

ok to test

2 similar comments
@ajschmidt8
Copy link
Member

ok to test

@firestarman
Copy link
Contributor Author

ok to test

@firestarman firestarman changed the title Add Java unit tests for window aggregate 'collect' Add Java unit tests for window aggregate 'collect' [skip ci] Feb 4, 2021
@firestarman
Copy link
Contributor Author

ok to test

@mythrocks
Copy link
Contributor

rerun tests

@mythrocks
Copy link
Contributor

mythrocks commented Feb 4, 2021 •
edited
Loading

Argh. I'm not sure why this PR's CI is "Pending". @firestarman, could you please git merge the latest from cudf/branch-0.18?

@galipremsagar
Copy link
Contributor

rerun tests

@mythrocks
Copy link
Contributor

mythrocks commented Feb 4, 2021 •
edited
Loading

This PR is pure JNI. It doesn't require the libcudf tests to run again.
Also, this PR only adds JNI tests. It has passed review. This should be safe to merge.

I'm going to try pinging the CI bot.

@mythrocks
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e2f6952 into rapidsai:branch-0.18 Feb 4, 2021
@firestarman firestarman deleted the window-agg-collect branch February 5, 2021 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythrocks mythrocks mythrocks approved these changes

@revans2 revans2 revans2 approved these changes

Assignees

@firestarman firestarman

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@firestarman @GPUtester @jlowe @mythrocks @ajschmidt8 @galipremsagar @revans2