Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java interface for the new API 'explode' [skip ci] #7151

Merged
merged 5 commits into from
Jan 25, 2021
Merged

Add Java interface for the new API 'explode' [skip ci] #7151

merged 5 commits into from
Jan 25, 2021

Conversation

firestarman
Copy link
Contributor

@firestarman firestarman commented Jan 15, 2021 •
edited
Loading

This PR is to add Java interface for the new API 'explode', along with its unit tests.

This PR depends on the PR #7140 .

@firestarman
Add JNI for the new API 'explode'.
be7ebd2 
Along with its unit tests.

Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman firestarman requested a review from a team as a code owner January 15, 2021 03:04
@GPUtester
Copy link
Collaborator

Can one of the admins verify this patch?

@firestarman firestarman reopened this Jan 15, 2021
@firestarman firestarman marked this pull request as draft January 15, 2021 03:09
@firestarman firestarman changed the title [WIP] Add Java interface for the new API 'explode'. Add Java interface for the new API 'explode' [skip ci] Jan 15, 2021
@jlowe jlowe added Java Affects Java cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 15, 2021
@jlowe
Copy link
Member

jlowe commented Jan 15, 2021

Needs 2021 copyrights added to the files but otherwise lgtm.

@firestarman
Update comments for nulls
ba98e1d 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Add null case for 'explode' test
58c07f0
@firestarman
Fix a bug in TableBuilder.
3095ce0 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Updated Copyright years
e801c24 
Signed-off-by: Liangcai Li <liangcail@nvidia.com>
@firestarman
Copy link
Contributor Author

Needs 2021 copyrights added to the files but otherwise lgtm.

Updated, thanks.

@firestarman firestarman marked this pull request as ready for review January 25, 2021 11:10
@firestarman
Copy link
Contributor Author

mark as review since PR7140 has been merged

@sperlingxx sperlingxx added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jan 25, 2021
@revans2
Copy link
Contributor

revans2 commented Jan 25, 2021

@gpucibot merge

@revans2
Copy link
Contributor

revans2 commented Jan 25, 2021

rerun tests

@ajschmidt8
Copy link
Member

ok to test

@revans2
Copy link
Contributor

revans2 commented Jan 25, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bf0c37a into rapidsai:branch-0.18 Jan 25, 2021
@GaryShen2008 GaryShen2008 mentioned this pull request Feb 10, 2021
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@revans2 revans2 revans2 approved these changes

@jlowe jlowe jlowe approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function Java Affects Java cuDF API. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@firestarman @GPUtester @jlowe @revans2 @ajschmidt8 @sperlingxx