Unpin from numpy < 1.20 #7335
Merged
Unpin from numpy < 1.20 #7335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkraus14
reviewed
Feb 5, 2021
kkraus14
approved these changes
Feb 5, 2021
kkraus14
added
improvement
raydouglass
approved these changes
Feb 5, 2021
Codecov Report
@@ Coverage Diff @@
## branch-0.18 #7335 +/- ##
===============================================
- Coverage 82.09% 81.80% -0.30%
===============================================
Files 97 100 +3
Lines 16474 16605 +131
===============================================
+ Hits 13524 13583 +59
- Misses 2950 3022 +72
Continue to review full report at Codecov.
|
raydouglass
requested changes
Feb 8, 2021
There was a problem hiding this comment.
I believe this change is also necessary in the meta.yaml: https://github.com/rapidsai/cudf/blob/branch-0.18/conda/recipes/cudf/meta.yaml#L41
|
Thanks @raydouglass - fixed! |
raydouglass
approved these changes
Feb 8, 2021
|
@gpucibot merge |
rwlee
pushed a commit
to rwlee/cudf
that referenced
this pull request
Feb 18, 2021
Authors: - Ashwin Srinath (@shwina) Approvers: - Keith Kraus (@kkraus14) - @jakirkham - Ray Douglass (@raydouglass) URL: rapidsai#7335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.