-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change device_vector to device_uvector for strings_column_view #7798
Change device_vector to device_uvector for strings_column_view #7798
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a copy error. Also opportunity to create a useful uvector utility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have any other concerns apart from what have been already raised.
Can you please put |
Absolutely. Are you ok with the name? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, rest looks good.
Is the async version of make_std_vector safe? Could the temp host array be freed before the copy completes? |
Codecov Report
@@ Coverage Diff @@
## branch-0.20 #7798 +/- ##
===============================================
+ Coverage 82.30% 82.34% +0.04%
===============================================
Files 101 103 +2
Lines 17053 17355 +302
===============================================
+ Hits 14035 14291 +256
- Misses 3018 3064 +46
Continue to review full report at Codecov.
|
There should be no temp host array since it is returned. |
@gpucibot merge |
References #7287
This replaces
device_vector
withdevice_uvector
instrings_column_view
functions.This cascaded to some dependent functions that needed to be updated as well.