-
Notifications
You must be signed in to change notification settings - Fork 904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Add backward compatibility for dask-cudf
to work with other versions of dask
#8368
[REVIEW] Add backward compatibility for dask-cudf
to work with other versions of dask
#8368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@galipremsagar can you bump the allowed dask package in the conda recipes / setup.py / requirements.txt files?
Ah I have those changes in PR ( #8363 ) |
I think that just bumps the required version whereas this PR allows the older version to continue working. Going to close it in favor of this PR. |
I think this needs to be updated as well: https://github.com/rapidsai/cudf/blob/branch-21.06/conda/recipes/custreamz/meta.yaml#L34-L35 |
@gpucibot merge |
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8368 +/- ##
===============================================
Coverage ? 82.87%
===============================================
Files ? 105
Lines ? 17883
Branches ? 0
===============================================
Hits ? 14821
Misses ? 3062
Partials ? 0 Continue to review full report at Codecov.
|
Thanks all! 😄 |
The current
dask-cudf
includes latest changes that work with latestdask
changes. But when an existing release version ofdask
is used withdask-cudf
it will fail to import some of the dispatches needed formake_meta
&make_meta_util
.. This PR will handle those import errors and have a fallback in place.