Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Add backward compatibility for dask-cudf to work with other versions of dask #8368

Merged
merged 4 commits into from
May 26, 2021

Conversation

galipremsagar
Copy link
Contributor

The current dask-cudf includes latest changes that work with latest dask changes. But when an existing release version of dask is used with dask-cudf it will fail to import some of the dispatches needed for make_meta & make_meta_util.. This PR will handle those import errors and have a fallback in place.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer non-breaking Non-breaking change labels May 26, 2021
@galipremsagar galipremsagar self-assigned this May 26, 2021
@galipremsagar galipremsagar requested a review from a team as a code owner May 26, 2021 15:35
@github-actions github-actions bot added the Python Affects Python cuDF API. label May 26, 2021
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galipremsagar can you bump the allowed dask package in the conda recipes / setup.py / requirements.txt files?

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs Dask Reviewer labels May 26, 2021
@jakirkham
Copy link
Member

Ah I have those changes in PR ( #8363 )

@kkraus14
Copy link
Collaborator

Ah I have those changes in PR ( #8363 )

I think that just bumps the required version whereas this PR allows the older version to continue working. Going to close it in favor of this PR.

@galipremsagar galipremsagar requested review from a team as code owners May 26, 2021 16:42
@kkraus14
Copy link
Collaborator

I think this needs to be updated as well: https://github.com/rapidsai/cudf/blob/branch-21.06/conda/recipes/custreamz/meta.yaml#L34-L35

@kkraus14
Copy link
Collaborator

@gpucibot merge

@codecov
Copy link

codecov bot commented May 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@cbbcba7). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head d097539 differs from pull request most recent head 0aa80db. Consider uploading reports for the commit 0aa80db to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #8368   +/-   ##
===============================================
  Coverage                ?   82.87%           
===============================================
  Files                   ?      105           
  Lines                   ?    17883           
  Branches                ?        0           
===============================================
  Hits                    ?    14821           
  Misses                  ?     3062           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbbcba7...0aa80db. Read the comment docs.

@rapids-bot rapids-bot bot merged commit e97fc1c into rapidsai:branch-21.06 May 26, 2021
@jakirkham
Copy link
Member

Thanks all! 😄

@vyasr vyasr added dask Dask issue and removed dask-cudf labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working dask Dask issue non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants