Set pass_filenames: false in mypy pre-commit configuration. #9349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
3 - Ready for Review
bdice
changed the title
bdice
requested review from
a team,
rgsl888prabhu and
brandon-b-miller
and removed request for
a team
galipremsagar
approved these changes
Sep 30, 2021
galipremsagar
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #9349 +/- ##
================================================
- Coverage 10.79% 10.77% -0.02%
================================================
Files 116 116
Lines 18869 19363 +494
================================================
+ Hits 2036 2087 +51
- Misses 16833 17276 +443
Continue to review full report at Codecov.
|
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a small mistake in PR #9300. I missed the setting
pass_filenames: false, which causes mypy to fail with an error about duplicate module names. This PR adds that setting back and fixes the error.