Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicts in 1643 #1651

Merged
merged 7 commits into from
Jun 7, 2021
Merged

Fix conflicts in 1643 #1651

merged 7 commits into from
Jun 7, 2021

Conversation

ajschmidt8
Copy link
Member

@ajschmidt8 ajschmidt8 commented Jun 7, 2021

This PR fixes the conflicts in #1643.

In particular, the following files had conflicts that I resolved:

  • conda/environments/cugraph_dev_cuda11.0.yml
  • conda/environments/cugraph_dev_cuda11.1.yml
  • conda/environments/cugraph_dev_cuda11.2.yml
  • conda/recipes/cugraph/meta.yaml

rlratzel and others added 7 commits June 3, 2021 15:06
Upgraded recipe and dev envs to NCCL 2.9.9.

The `cugraph` python conda recipe previously included NCCL, but (I think) it's a transient dependency since `libcugraph` actually needs it, so it was removed from the `cugraph` recipe.

cc @dantegd for consistency with cuML.

Note: the NCCL 2.9.9 upgrade was tested during benchmark runs, but the conda recipe changes have not been tested.

Authors:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Jordan Jacobelli (https://github.com/Ethyling)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #1636
This effort was originally targeted toward the WCC effort, but has been expanded a bit.  This supersedes #1545 which I will close.

The goal here is to create a means for constructing test graphs in an easier fashion.  Testing the capabilities of different graph algorithms might require a variety of graphs.  The objective of this PR is to better organize the graph generation components and to introduce some components to help in composing graphs out of multiple components.

This PR introduces the following capabilities:
* Create an ER graph
* Create a collection of Complete Graphs
* Create a collection of 2D mesh graphs
* Create a collection of 3D mesh graphs
* Create a random path graph (connect all vertices with a single randomly ordered path)
* Translate vertex ids of a graph
* Combine multiple edge lists into a single graph

Closes #1543

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Andrei Schaffer (https://github.com/aschaffer)
  - Brad Rees (https://github.com/BradReesWork)

URL: #1603
Should be merged after PR #1636.

- Undo NCCL 2.9.6 bug workarounds.
- MG WCC weak scaling improvements.

Authors:
  - Seunghwa Kang (https://github.com/seunghwak)
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Andrei Schaffer (https://github.com/aschaffer)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #1628
…1648)

Made call to cugraph.random_walks() ignore the unused return value.

Manually tested in browser with jupyterlab.

Author:
  - Rick Ratzel (https://github.com/rlratzel)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - AJ Schmidt (https://github.com/ajschmidt8)

URL: #1648
@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2021
@ajschmidt8 ajschmidt8 requested review from a team as code owners June 7, 2021 16:29
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ajschmidt8 ajschmidt8 merged commit 6aab21f into rapidsai:branch-21.08 Jun 7, 2021
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the conda env files and recipe, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants