Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accidentally-removed cpp-mgtests target back to the valid args list #1652

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Jun 7, 2021

Added accidentally-removed cpp-mgtests target back to the valid args list. This was removed during an update to add --buildfaiss, likely due to a bad merge?

Tested by running with the target and observing the MG tests being built and the MPI library being pulled in (still building, will update if something goes wrong)

@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Jun 7, 2021
@rlratzel rlratzel requested a review from hlinsen June 7, 2021 19:05
@rlratzel rlratzel self-assigned this Jun 7, 2021
@BradReesWork BradReesWork added this to the 21.08 milestone Jun 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@6aab21f). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head cbfb8dd differs from pull request most recent head 3dd7ff1. Consider uploading reports for the commit 3dd7ff1 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #1652   +/-   ##
===============================================
  Coverage                ?   59.79%           
===============================================
  Files                   ?       80           
  Lines                   ?     3542           
  Branches                ?        0           
===============================================
  Hits                    ?     2118           
  Misses                  ?     1424           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6aab21f...3dd7ff1. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e47c396 into rapidsai:branch-21.08 Jun 15, 2021
@rlratzel rlratzel deleted the branch-21.08-buildscriptfix branch June 17, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants