Sort local neighbors in the graph adjacency list. #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunghwak
added
3 - Ready for Review
improvement
…ort_adjacency_list
aschaffer
reviewed
Oct 15, 2021
| offset_first, | ||
| offset_first + 1, | ||
| 0, | ||
| sizeof(vertex_t) * 8, |
There was a problem hiding this comment.
sizeof(vertex_t) << 3 should be faster (although, most likely optimized out by the compiler, anyway)
There was a problem hiding this comment.
Yes... and this will be executed only few times per graph creation, so even without optimization, this will increase execution time by only few nanoseconds, better go for clarity.
aschaffer
approved these changes
Oct 15, 2021
seunghwak
added
2 - In Progress
DO NOT MERGE
seunghwak
added
3 - Ready for Review
and removed
2 - In Progress
DO NOT MERGE
ChuckHastings
approved these changes
Oct 18, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for implementing Node2Vec and triangle counting (and also improves edge traversal performance as this improves locality of row/column property accesses).