Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update input argument check for graph_t constructor and remove expensive input argument check for graph_view_t #1890

Merged
merged 6 commits into from
Oct 19, 2021
Merged

Update input argument check for graph_t constructor and remove expensive input argument check for graph_view_t #1890

merged 6 commits into from
Oct 19, 2021

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Oct 18, 2021 •
edited
Loading

Close #1892

  • Check for graph properties passed by the caller (multigrpah, symmetric).
  • Remove expensive check for graph_view_t (graph_view_t is not to be called by user, only called by graph_t)

@seunghwak seunghwak requested a review from a team as a code owner October 18, 2021 16:05
@seunghwak seunghwak self-assigned this Oct 18, 2021
@seunghwak seunghwak added 2 - In Progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 18, 2021
@seunghwak seunghwak changed the title Update input argument check for graph_t constructor and remove expensive input argument check for graph_view_t [WIP] Update input argument check for graph_t constructor and remove expensive input argument check for graph_view_t Oct 18, 2021
@seunghwak seunghwak changed the title [WIP] Update input argument check for graph_t constructor and remove expensive input argument check for graph_view_t Update input argument check for graph_t constructor and remove expensive input argument check for graph_view_t Oct 18, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@33361d0). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1890   +/-   ##
===============================================
  Coverage                ?   70.08%           
===============================================
  Files                   ?      143           
  Lines                   ?     8817           
  Branches                ?        0           
===============================================
  Hits                    ?     6179           
  Misses                  ?     2638           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33361d0...5178958. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.12 milestone Oct 19, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 285ffc0 into rapidsai:branch-21.12 Oct 19, 2021
@seunghwak seunghwak deleted the enh_expensive_check branch October 20, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@kaatish kaatish Awaiting requested review from kaatish

Assignees

@seunghwak seunghwak

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.12
Development

Successfully merging this pull request may close these issues.

[ENH] Update user input argument checks for graph_t constructors.
4 participants
@seunghwak @codecov-commenter @BradReesWork @ChuckHastings