Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some unused code in the C API (and beyond) #2339

Merged
merged 6 commits into from
Jun 6, 2022

Conversation

ChuckHastings
Copy link
Collaborator

Cleaning up some unused code in the C API, and some old visitor methods that are no longer used once this code is gone.

@ChuckHastings ChuckHastings self-assigned this Jun 6, 2022
@ChuckHastings ChuckHastings added 2 - In Progress improvement Improvement / enhancement to an existing function breaking Breaking change labels Jun 6, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jun 6, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@4922450). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2339   +/-   ##
===============================================
  Coverage                ?   60.74%           
===============================================
  Files                   ?      105           
  Lines                   ?     5075           
  Branches                ?        0           
===============================================
  Hits                    ?     3083           
  Misses                  ?     1992           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4922450...6ed7706. Read the comment docs.

@ChuckHastings ChuckHastings marked this pull request as ready for review June 6, 2022 19:57
@ChuckHastings ChuckHastings requested review from a team as code owners June 6, 2022 19:57
@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a1c9141 into rapidsai:branch-22.08 Jun 6, 2022
@ChuckHastings ChuckHastings deleted the c_api_cleanup2 branch August 4, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants