Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PageRank to leverage pylibcugraph #2467

Merged
merged 50 commits into from
Aug 4, 2022
Merged

Update PageRank to leverage pylibcugraph #2467

merged 50 commits into from
Aug 4, 2022

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Jul 28, 2022 •
edited
Loading

This PR

  1. Extends the capabilities of the PageRank CAPI to the python cuGraph API
  2. Update or Add support for the parameters personalization precomputed_vertex_out_weight and nstart for both the SG and MG implementation

closes #2455
closes #2430

@jnke2016 jnke2016 marked this pull request as ready for review July 28, 2022 17:49
@jnke2016 jnke2016 requested a review from a team as a code owner July 28, 2022 17:49
@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 29, 2022
@BradReesWork BradReesWork added this to the 22.08 milestone Jul 29, 2022
@jnke2016 jnke2016 requested a review from a team as a code owner July 31, 2022 20:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.08@4dc286e). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.08    #2467   +/-   ##
===============================================
  Coverage                ?   61.33%           
===============================================
  Files                   ?      106           
  Lines                   ?     5625           
  Branches                ?        0           
===============================================
  Hits                    ?     3450           
  Misses                  ?     2175           
  Partials                ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jnke2016 jnke2016 requested a review from a team as a code owner August 1, 2022 04:11
@jnke2016 jnke2016 requested a review from a team as a code owner August 3, 2022 13:53
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@ChuckHastings ChuckHastings mentioned this pull request Aug 3, 2022
Closed
rlratzel
rlratzel reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a quick request for a FIXME.
Also, can you update the description to say it closes #2430 too?

python/cugraph/cugraph/dask/link_analysis/pagerank.py Show resolved Hide resolved
python/cugraph/cugraph/link_analysis/pagerank.py Show resolved Hide resolved
@rlratzel
Copy link
Contributor

rlratzel commented Aug 3, 2022

@gpucibot merge

@rlratzel
Copy link
Contributor

rlratzel commented Aug 4, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cdc563f into rapidsai:branch-22.08 Aug 4, 2022
@ChuckHastings ChuckHastings mentioned this pull request Aug 15, 2022
Merged
rapids-bot bot pushed a commit that referenced this pull request Aug 16, 2022
@ChuckHastings
remove pagerank from cython.cu (#2587)
903bc60 
Closes #2499 

Now that #2467 has been merged we can remove the call_pagerank functionality from `cython.cu`.

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #2587
@jnke2016 jnke2016 deleted the branch-22.08_fea-pylibcugraph-pagerank branch September 24, 2022 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChuckHastings ChuckHastings ChuckHastings approved these changes

@rlratzel rlratzel rlratzel approved these changes

@seunghwak seunghwak seunghwak approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
22.08
6 participants
@jnke2016 @codecov-commenter @rlratzel @ChuckHastings @seunghwak @BradReesWork