Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unneeded test dependency on cugraph from pylibcugraph tests #2738

Merged

Conversation

rlratzel
Copy link
Contributor

@rlratzel rlratzel commented Sep 26, 2022

closes #2737

  • Uses the same util from pylibcugraph.testing instead of cugraph.testing
  • Removes a renumbering test that uses cugraph/cudf and instead relies on the test that uses cupy that provides the same coverage

…hich also had basically the same coverage elsewhere), imported util from PLC instead of cugraph.
@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Sep 26, 2022
@rlratzel rlratzel added this to the 22.10 milestone Sep 26, 2022
@rlratzel rlratzel requested a review from a team as a code owner September 26, 2022 23:21
@rlratzel rlratzel self-assigned this Sep 26, 2022
@vyasr
Copy link
Contributor

vyasr commented Sep 26, 2022

Thanks for the quick turnaround on this!

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@f0c1e99). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 694ae06 differs from pull request most recent head 6223994. Consider uploading reports for the commit 6223994 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10    #2738   +/-   ##
===============================================
  Coverage                ?   59.79%           
===============================================
  Files                   ?      111           
  Lines                   ?     6184           
  Branches                ?        0           
===============================================
  Hits                    ?     3698           
  Misses                  ?     2486           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 86da00d into rapidsai:branch-22.10 Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pylibcugraph depends on cugraph for certain tests
4 participants