MNT Removes unused optim_batch_size from UMAP's docstring #4732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
cjnolet
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #4732 +/- ##
=============================================
Coverage 79.89% 79.89%
=============================================
Files 180 180
Lines 11371 11371
=============================================
Hits 9085 9085
Misses 2286 2286
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dantegd
approved these changes
May 13, 2022
|
Thanks for the fix @thomasjpfan ! |
|
@gpucibot merge |
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
) Closes rapidsai#4725 rapidsai#3848 removes the usage of `optim_batch_size` in code. This PR removes the parameter from the docstring and in `UMAPParams`. Authors: - Thomas J. Fan (https://github.com/thomasjpfan) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4725
#3848 removes the usage of
optim_batch_sizein code. This PR removes the parameter from the docstring and inUMAPParams.