Allow CuPy 11 #4837
Merged
Allow CuPy 11 #4837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could someone please help add the appropriate labels here? |
dantegd
added
improvement
sevagh
approved these changes
Jul 28, 2022
dantegd
reviewed
Jul 28, 2022
| @@ -51,7 +51,7 @@ requirements: | |||
| - libcuml={{ version }} | |||
| - libcumlprims {{ minor_version }} | |||
| - pyraft {{ minor_version }} | |||
| - cupy>=7.8.0,<11.0.0a0 | |||
| - cupy>=7.8.0,<12.0.0a0 | |||
There was a problem hiding this comment.
Small question, should we do the same for the dev environments?
There was a problem hiding this comment.
We can do that. Looked at the environment files here, but didn't see cupy listed. Do we want to add it as part of this PR?
There was a problem hiding this comment.
I think currently it is tied to the meta packages or brought by cudf, so we should be fine with the PR as is
There was a problem hiding this comment.
Sounds good. Happy to follow up if needed :)
dantegd
approved these changes
Jul 28, 2022
|
@gpucibot merge |
|
Thanks all! 🙏 |
galipremsagar
added a commit
to galipremsagar/cuml
that referenced
this pull request
Aug 1, 2022
This reverts commit dc77d6b.
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Aug 1, 2022
Reverts #4837 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: #4847
jakirkham
added a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
Allows cuML to be installed with CuPy 11. xref: rapidsai/integration#508 Authors: - https://github.com/jakirkham Approvers: - Sevag H (https://github.com/sevagh) - Dante Gama Dessavre (https://github.com/dantegd) URL: rapidsai#4837
jakirkham
pushed a commit
to jakirkham/cuml
that referenced
this pull request
Feb 27, 2023
Reverts rapidsai#4837 Authors: - GALI PREM SAGAR (https://github.com/galipremsagar) Approvers: - Dante Gama Dessavre (https://github.com/dantegd) - Ray Douglass (https://github.com/raydouglass) URL: rapidsai#4847
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows cuML to be installed with CuPy 11.
xref: rapidsai/integration#508