Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow nightly dependencies and set up consistent nightly versions for conda and pip packages #5607

Merged
merged 28 commits into from
Oct 31, 2023
Merged

Allow nightly dependencies and set up consistent nightly versions for conda and pip packages #5607

merged 28 commits into from
Oct 31, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Oct 6, 2023

This PR applies analogous changes to rapidsai/rmm#1335 and rapidsai/rmm#1347.

@vyasr vyasr added conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change ci labels Oct 6, 2023
@vyasr vyasr self-assigned this Oct 6, 2023
@vyasr vyasr requested review from a team as code owners October 6, 2023 00:06
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Oct 6, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 6, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

csadorf
csadorf requested changes Oct 6, 2023
View reviewed changes
ci/build_python.sh Outdated Show resolved Hide resolved
ci/build_wheel.sh Show resolved Hide resolved
conda/recipes/cuml-cpu/meta.yaml Show resolved Hide resolved
python/cuml/__init__.py Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from csadorf October 6, 2023 17:32
csadorf
csadorf approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback! LGTM!

ajschmidt8
ajschmidt8 approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor comments/suggestions but LGTM otherwise

ci/build_python.sh Outdated Show resolved Hide resolved
ci/build_python.sh Outdated Show resolved Hide resolved
ci/build_wheel.sh Outdated Show resolved Hide resolved
vyasr and others added 3 commits October 6, 2023 13:10
divyegala
divyegala reviewed Oct 10, 2023
View reviewed changes
ci/build_wheel.sh Outdated Show resolved Hide resolved
csadorf
csadorf approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@csadorf csadorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving recent changes.

@vyasr vyasr requested a review from a team as a code owner October 24, 2023 19:02
csadorf
csadorf reviewed Oct 25, 2023
View reviewed changes
python/cuml/_version.py Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor Author

vyasr commented Oct 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 4c36b19 into rapidsai:branch-23.12 Oct 31, 2023
52 checks passed
@vyasr vyasr deleted the feat/nightly_versions branch October 31, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyegala divyegala divyegala approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@csadorf csadorf csadorf approved these changes

@dantegd dantegd dantegd approved these changes

Assignees

@vyasr vyasr

Labels
ci conda conda issue Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vyasr @dantegd @csadorf @ajschmidt8 @divyegala