Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use functions in the limited API #5871

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Apr 26, 2024

This PR removes usage of the only method in raft's Cython that is not part of the Python limited API. Contributes to rapidsai/build-planning#42

@vyasr vyasr added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 26, 2024
@vyasr vyasr self-assigned this Apr 26, 2024
@vyasr vyasr requested review from a team as code owners April 26, 2024 23:21
@github-actions github-actions bot added Cython / Python Cython or Python issue CMake labels Apr 26, 2024
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat! Love seeing the improvement towards moving us to the Python limited API! Thanks @vyasr

@dantegd
Copy link
Member

dantegd commented Apr 30, 2024

/merge

@rapids-bot rapids-bot bot merged commit 3c1a72c into rapidsai:branch-24.06 Apr 30, 2024
60 checks passed
@vyasr vyasr deleted the feat/py_limited_api_compat branch April 30, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants