Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH Build with cmake --build & Pass ccache variables to conda recipe & use Ninja in CI #359

Merged
merged 3 commits into from
Feb 23, 2021
Merged

ENH Build with cmake --build & Pass ccache variables to conda recipe & use Ninja in CI #359

merged 3 commits into from
Feb 23, 2021

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Feb 17, 2021 •
edited
Loading

  • Build using cmake --build
  • Pass ccache variables to conda recipe
  • Use Ninja in CI

@jjacobelli jjacobelli added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 17, 2021
@jjacobelli jjacobelli requested a review from a team as a code owner February 17, 2021 16:10
@jjacobelli jjacobelli changed the title ENH Build with cmake --build & Pass ccache variables to conda recipe [WIP] ENH Build with cmake --build & Pass ccache variables to conda recipe Feb 17, 2021
@jjacobelli jjacobelli changed the title [WIP] ENH Build with cmake --build & Pass ccache variables to conda recipe ENH Build with cmake --build & Pass ccache variables to conda recipe Feb 17, 2021
@jjacobelli jjacobelli added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Feb 17, 2021
@jjacobelli
ENH Pass ccache variables to conda recipe
fd0b8cf 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli
ENH Build with cmake --build
e01ba44 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli changed the title ENH Build with cmake --build & Pass ccache variables to conda recipe ENH Build with cmake --build & Pass ccache variables to conda recipe & use Ninja in CI Feb 22, 2021
@jjacobelli
ENH Use Ninja to build in CI
daf32ad 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@dillon-cullinan
Copy link
Contributor

rerun tests

@dillon-cullinan
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4c38aa8 into rapidsai:branch-0.19 Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillon-cullinan dillon-cullinan dillon-cullinan approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjacobelli @dillon-cullinan