Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KNN bruteforce and IVF methods C/C++ API #33

Merged
merged 30 commits into from
Mar 20, 2024
Merged

KNN bruteforce and IVF methods C/C++ API #33

merged 30 commits into from
Mar 20, 2024

Conversation

viclafargue
Copy link
Contributor

No description provided.

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Feb 7, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cjnolet cjnolet changed the base branch from branch-24.02 to branch-24.04 February 13, 2024 15:53
@viclafargue viclafargue marked this pull request as ready for review February 19, 2024 10:47
@viclafargue viclafargue changed the title Adding KNN bruteforce and IVF methods KNN bruteforce and IVF methods C++ API Feb 26, 2024
lowener
lowener reviewed Feb 28, 2024
View reviewed changes
cpp/include/cuvs/neighbors/brute_force.hpp Outdated Show resolved Hide resolved
cpp/include/cuvs/neighbors/brute_force.hpp Outdated Show resolved Hide resolved
cpp/src/neighbors/brute_force.cpp Outdated Show resolved Hide resolved
cpp/test/neighbors/ann_ivf_pq/test_float_int64_t.cu Outdated Show resolved Hide resolved
@viclafargue viclafargue requested review from a team as code owners March 1, 2024 10:48
@cjnolet cjnolet added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 4, 2024
@cjnolet
Copy link
Member

cjnolet commented Mar 4, 2024

/ok to test

cjnolet
cjnolet requested changes Mar 12, 2024
View reviewed changes
Copy link
Member

@cjnolet cjnolet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are getting very close! We need to make sure we are adding these things to the docs as we move them over to cuVS, since the docs will utlimately be the place where we point users to learn more.

cpp/include/cuvs/neighbors/ivf_pq.hpp Outdated Show resolved Hide resolved
cpp/include/cuvs/neighbors/ivf_pq.hpp Outdated Show resolved Hide resolved
cpp/include/cuvs/neighbors/ivf_pq.hpp

#pragma once

#include "ann_types.hpp"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as a TODO: I'd like to rename ann_types.hpp to index.hpp.

cpp/src/neighbors/brute_force.cu Outdated Show resolved Hide resolved
cpp/include/cuvs/distance/distance_types.h Show resolved Hide resolved
cpp/src/neighbors/ivf_flat_build_float.cpp Outdated Show resolved Hide resolved
@viclafargue viclafargue requested a review from a team as a code owner March 18, 2024 17:37
@github-actions github-actions bot added the ci label Mar 18, 2024
@github-actions github-actions bot removed the ci label Mar 18, 2024
@viclafargue viclafargue requested a review from a team as a code owner March 18, 2024 18:56
benfred
benfred approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@benfred benfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks @viclafargue

@benfred
Copy link
Member

benfred commented Mar 19, 2024

/ok to test

@benfred
Copy link
Member

benfred commented Mar 20, 2024

/ok to test

@benfred
Copy link
Member

benfred commented Mar 20, 2024

/merge

@rapids-bot rapids-bot bot merged commit 18bab30 into rapidsai:branch-24.04 Mar 20, 2024
55 checks passed
benfred pushed a commit to benfred/cuvs that referenced this pull request Apr 5, 2024
@viclafargue @benfred
KNN bruteforce and IVF methods C/C++ API (rapidsai#33)
0db75d0 
Authors:
  - Victor Lafargue (https://github.com/viclafargue)
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Ben Frederickson (https://github.com/benfred)
  - Corey J. Nolet (https://github.com/cjnolet)
  - Jake Awe (https://github.com/AyodeAwe)

URL: rapidsai#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd left review comments

@tfeher tfeher tfeher left review comments

@lowener lowener lowener left review comments

@benfred benfred benfred approved these changes

@cjnolet cjnolet cjnolet approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

Assignees

@viclafargue viclafargue

Labels
CMake cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@viclafargue @cjnolet @benfred @dantegd @tfeher @lowener @AyodeAwe