Resolve dask-sql/distributed build failures #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
changed the title
charlesbluca
commented
Oct 30, 2023
| @@ -34,6 +37,7 @@ RUN cat /rapids.yml \ | |||
|
|
|||
| # need to unpin dask, pyarrow, and uvicorn in python 3.9 environment | |||
| RUN cat /dask.yml \ | |||
| | sed -r "s/libprotobuf=/libprotobuf>=/g" \ | |||
There was a problem hiding this comment.
Normally it would make more sense to address this conflict directly in dask-sql; however, since it seems like we're generally going to drop this dep soon anyways with dask-contrib/dask-sql#1249 figured a short term unblocker would be good for now
There was a problem hiding this comment.
Agreed, a short-term fix is reasonable.
pentschev
approved these changes
Oct 30, 2023
| @@ -34,6 +37,7 @@ RUN cat /rapids.yml \ | |||
|
|
|||
| # need to unpin dask, pyarrow, and uvicorn in python 3.9 environment | |||
| RUN cat /dask.yml \ | |||
| | sed -r "s/libprotobuf=/libprotobuf>=/g" \ | |||
There was a problem hiding this comment.
Agreed, a short-term fix is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to
rapidsai/miniforge-cudabase images introduced a couple small build failures that this should fix; in particular:wgetinstallation in dask-sql's images to installrustuplibprotobufpinning to avoid conflict with cuDFcrick